Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused_peekable closure and f(&mut peekable) false positives #9465

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

Alexendoo
Copy link
Member

@Alexendoo Alexendoo commented Sep 11, 2022

changelog: Fix [unused_peekable] false positive when peeked in a closure or called as f(&mut peekable)

The return/break changes aren't part of the fix, they allow an earlier return in some cases. break is replaced with return for style purposes as they do the same thing in this case

Fixes #9456
Fixes #9462

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 11, 2022
@Alexendoo
Copy link
Member Author

Not sure on the timing of things but I'll add beta-nominated Nominated for backporting to the compiler in the beta channel. here too

@Alexendoo Alexendoo added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 12, 2022
@flip1995
Copy link
Member

@bors r+

Thanks! Since this lint was already reported twice I will do a dummy sync with this commit.

@bors
Copy link
Contributor

bors commented Sep 14, 2022

📌 Commit 86d18b5 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 14, 2022

⌛ Testing commit 86d18b5 with merge 9c9aa92...

@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Sep 14, 2022
@bors
Copy link
Contributor

bors commented Sep 14, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 9c9aa92 to master...

@bors bors merged commit 9c9aa92 into rust-lang:master Sep 14, 2022
@flip1995
Copy link
Member

rust-lang/rust#101811

@Alexendoo Alexendoo deleted the peekable-fp branch September 14, 2022 15:32
@flip1995 flip1995 removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
4 participants