Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating issue templates again for rustbot #7627

Merged
merged 2 commits into from
Sep 5, 2021

Conversation

xFrednet
Copy link
Member

@xFrednet xFrednet commented Sep 3, 2021

It turns out that our current issue template can sometimes trigger a rustbot error message, as can be seen in #7626. I originally tested this in #7599, but it's apparently a bit inconsistent. This PR adds backticks to the commands, as correctly suggested by @mikerite in the comments. (Thank you!)

@rustbot label +S-blocked


Now I also pushed a tiny link fix as well. 🙃


changelog: none

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 3, 2021
@xFrednet xFrednet force-pushed the 0000-updating-issue-templates-again branch 2 times, most recently from cb0ff25 to 0875445 Compare September 3, 2021 13:34
@ghost
Copy link

ghost commented Sep 3, 2021

Why not surround the whole commad in backticks? I'm sure people will know to remove them.

Or does that have the same issue?

@xFrednet
Copy link
Member Author

xFrednet commented Sep 3, 2021

The issue is that GitHub ignores backticks inside comments. At least rustbot still triggers with them. I'll ping you inside an HTML comment with backticks as an example

@xFrednet
Copy link
Member Author

xFrednet commented Sep 3, 2021

Well now it's somehow not triggering rustbot with the backticks. Maybe I missed that in my tests earlier

@xFrednet
Copy link
Member Author

xFrednet commented Sep 3, 2021

You're right, nice catch! Thank you!

@xFrednet xFrednet force-pushed the 0000-updating-issue-templates-again branch from 0875445 to 169aea6 Compare September 3, 2021 13:58
@llogiq
Copy link
Contributor

llogiq commented Sep 4, 2021

From my side, this looks Ok. r=me if you think it's ready to merge.

@xFrednet
Copy link
Member Author

xFrednet commented Sep 5, 2021

@bors r=llogiq

@bors
Copy link
Contributor

bors commented Sep 5, 2021

📌 Commit 169aea6 has been approved by llogiq

@bors
Copy link
Contributor

bors commented Sep 5, 2021

⌛ Testing commit 169aea6 with merge df7e63b...

@bors
Copy link
Contributor

bors commented Sep 5, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing df7e63b to master...

@bors bors merged commit df7e63b into rust-lang:master Sep 5, 2021
@xFrednet xFrednet deleted the 0000-updating-issue-templates-again branch September 5, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants