Code

Rollup of 6 pull requests#5866

Code

Closed

flip1995 wants to merge 37 commits intorust-lang:masterrust-lang/rust-clippy:masterfrom flip1995:rollup-ovtjqh4flip1995/rust-clippy:rollup-ovtjqh4Copy head branch name to clipboard

+1,443-196

Commits

Commits on Jul 27, 2020

• run cargo dev new_lint

  Show description for 5a64496
  Ryan1729

  committed
  5a64496

  Copy full SHA for 5a64496

• move derive_ord_xor_partial_ord into derive mod so we can reuse derive_hash_xor_partial_eq code later

  Ryan1729

  committed
  fc20ee6

  Copy full SHA for fc20ee6

• add test for derive_ord_xor_partial_ord based on test for derive_hash_xor_partial_eq

  Ryan1729

  committed
  0722991

  Copy full SHA for 0722991

• initial implementation based on code for derive_hash_xor_partial_eq which is showing one error when there should be four

  Ryan1729

  committed
  068acbd

  Copy full SHA for 068acbd

• use get_trait_def_id to check for Ord trait

  Ryan1729

  committed
  a8d6eda

  Copy full SHA for a8d6eda

• update reference since we see the expected four errors

  Ryan1729

  committed
  6c3e459

  Copy full SHA for 6c3e459

• remove is_local check since getting the def_id directly makes it unnecessary

  Ryan1729

  committed
  7dc9748

  Copy full SHA for 7dc9748

• add description for derive_ord_xor_partial_ord

  Ryan1729

  committed
  431924c

  Copy full SHA for 431924c

• run cargo dev fmt and fix overly long line

  Ryan1729

  committed
  668b747

  Copy full SHA for 668b747

• s/pord/partial_ord/ to fix dogfood failure

  Ryan1729

  committed
  ca03f2b

  Copy full SHA for ca03f2b

• fill in lint description for DERIVE_ORD_XOR_PARTIAL_ORD

  Ryan1729

  committed
  12a6eee

  Copy full SHA for 12a6eee

• run cargo dev update_lints

  Ryan1729

  committed
  94b10a6

  Copy full SHA for 94b10a6

Commits on Jul 28, 2020

• Lint duplicate methods of trait bounds

  Show description for 94c50bc
  wiomoc

  committed
  94c50bc

  Copy full SHA for 94c50bc

Commits on Jul 29, 2020

• typo fix

  wiomoc

  committed
  2b7fde6

  Copy full SHA for 2b7fde6

• should_impl_trait - ignore methods with lifetime params

  tnielens

  committed
  c0aa07d

  Copy full SHA for c0aa07d

• should_implement_trait - add test cases for every checked trait method

  tnielens

  committed
  93812c1

  Copy full SHA for 93812c1

• should_implement_trait - pr remarks

  tnielens

  committed
  f7a73f1

  Copy full SHA for f7a73f1

• should_implement_trait - filter on explicit lifetime param only

  tnielens

  committed
  d7e3f34

  Copy full SHA for d7e3f34

Commits on Jul 30, 2020

• Handle mapping to Option in map_flatten lint

  dima74

  committed
  a427c99

  Copy full SHA for a427c99

• Review fixes

  dima74

  committed
  d4ba561

  Copy full SHA for d4ba561

Commits on Jul 31, 2020

• should_impl_trait - pr comments

  tnielens

  committed
  108032e

  Copy full SHA for 108032e

Commits on Aug 2, 2020

• Remove old Symbol reexport

  Show description for cb00cdf
  phansch

  committed
  cb00cdf

  Copy full SHA for cb00cdf

• fmt

  phansch

  committed
  bb6e857

  Copy full SHA for bb6e857

Commits on Aug 3, 2020

• Create test for wanted behavior

  JarredAllen

  committed
  05bb6e6

  Copy full SHA for 05bb6e6

• Write the lint and write tests

  JarredAllen

  committed
  3ee6137

  Copy full SHA for 3ee6137

• Check for other things which can be used indirectly

  JarredAllen

  committed
  3657c92

  Copy full SHA for 3657c92

• Split indirect collects into their own test case

  JarredAllen

  committed
  c86f410

  Copy full SHA for c86f410

• Fix formatting and dogfood fallout

  JarredAllen

  committed
  a849483

  Copy full SHA for a849483

• Fix a bug causing it to be too trigger-happy

  JarredAllen

  committed
  bb2c14e

  Copy full SHA for bb2c14e

• Implement review suggestions

  JarredAllen

  committed
  5e10b03

  Copy full SHA for 5e10b03

• early return on empty parameters/where clause

  wiomoc

  committed
  e521c67

  Copy full SHA for e521c67

Commits on Aug 4, 2020

• Rollup merge of rust-lang#5725 - montrivo:should-impl-trait, r=flip1995,yaahc

  Show description for b008959
  flip1995

  authored
  b008959

  Copy full SHA for b008959

• Rollup merge of rust-lang#5837 - JarredAllen:needless_collect, r=phansch

  Show description for ed967e6
  flip1995

  authored
  ed967e6

  Copy full SHA for ed967e6

• Rollup merge of rust-lang#5846 - dima74:map_flatten.map_to_option, r=flip1995

  Show description for 617dc78
  flip1995

  authored
  617dc78

  Copy full SHA for 617dc78

• Rollup merge of rust-lang#5848 - Ryan1729:add-derive_ord_xor_partial_ord-lint, r=matthiaskrgr

  Show description for e2d2e0e
  flip1995

  authored
  e2d2e0e

  Copy full SHA for e2d2e0e

• Rollup merge of rust-lang#5852 - wiomoc:feature/lint-duplicate-trait, r=Manishearth

  Show description for 3e89f05
  flip1995

  authored
  3e89f05

  Copy full SHA for 3e89f05

• Rollup merge of rust-lang#5856 - phansch:remove-symbol-reexport, r=flip1995

  Show description for 59e901c
  flip1995

  authored
  59e901c

  Copy full SHA for 59e901c