Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Filter map lint #4521

Closed
wants to merge 3 commits into from
Closed

WIP: Filter map lint #4521

wants to merge 3 commits into from

Conversation

derivmug
Copy link

@derivmug derivmug commented Sep 7, 2019

changelog: WIP: Add new lint to detect unnecessary usage of map().flatten()

@derivmug derivmug mentioned this pull request Sep 7, 2019
Closed
@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 9, 2019
@flip1995 flip1995 self-requested a review September 9, 2019 14:43
@bors
Copy link
Collaborator

bors commented Sep 20, 2019

☔ The latest upstream changes (presumably #4511) made this pull request unmergeable. Please resolve the merge conflicts.

@flip1995 flip1995 added the A-lint Area: New lints label Nov 25, 2019
@flip1995
Copy link
Member

Sorry for the late reply

We already have the map_flatten lint. I think it would be better to improve this lint, by adding better documentation with better/more examples.

@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties A-lint Area: New lints labels Mar 30, 2020
flip1995
flip1995 requested changes Mar 30, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@flip1995
Copy link
Member

Thanks for contributing to Clippy! Sadly this PR was not updated in quite some time. If you waited on input from a reviewer, we're sorry that this fell under the radar. If you want to continue to work on this, just reopen the PR and/or ping a reviewer.

@flip1995 flip1995 closed this May 25, 2020
@flip1995 flip1995 added S-inactive-closed Status: Closed due to inactivity and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 requested changes

Assignees
No one assigned
Labels
S-inactive-closed Status: Closed due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derivmug @bors @flip1995 @lucabeetz