redundant_closure_for_method_calls fixes #4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #3942 |
|
What's the reasoning behind the mutability change? Could you rebase this onto master and squash some commits? $ git fetch upstream # upstream is this repo
$ git rebase -i upstream/master |
|
@flip1995 |
g-bartoszek
force-pushed
the
redundant-closure-deref
branch
from
01b6833 to
3a92723
Compare
|
Ah, thanks for the insight. LGTM. Can you squash the commit 3a92723? That seems kind of pointless. |
g-bartoszek
force-pushed
the
redundant-closure-deref
branch
from
3a92723 to
25631ce
Compare
|
Can you remove the file |
flip1995
added
the
S-waiting-on-author
lint does not trigger when there is a difference in mutability lint does not trigger when the method belongs to a trait which is not implemebted directly (Deref)
g-bartoszek
force-pushed
the
redundant-closure-deref
branch
from
25631ce to
d4ad23b
Compare
|
Done. I missed it too. |
|
Thanks! @bors r+ |
|
📌 Commit d4ad23b has been approved by |
bors
added a commit
that referenced
this pull request
Jun 12, 2019
redundant_closure_for_method_calls fixes lint does not trigger when there is a difference in mutability lint does not trigger when the method belongs to a trait which is not implemebted directly (Deref) <!-- Thank you for making Clippy better! We're collecting our changelog from pull request descriptions. If your PR only updates to the latest nightly, you can leave the `changelog` entry as `none`. Otherwise, please write a short comment explaining your change. If your PR fixes an issue, you can add "fixes #issue_number" into this PR description. This way the issue will be automatically closed when your PR is merged. If you added a new lint, here's a checklist for things that will be checked during review or continuous integration. - [ ] Followed [lint naming conventions][lint_naming] - [ ] Added passing UI tests (including committed `.stderr` file) - [ ] `cargo test` passes locally - [ ] Executed `util/dev update_lints` - [ ] Added lint documentation - [ ] Run `cargo fmt` Note that you can skip the above if you are just opening a WIP PR in order to get feedback. Delete this line and everything above before opening your PR --> changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint does not trigger when there is a difference in mutability
lint does not trigger when the method belongs to a trait which is not implemebted directly (Deref)
changelog: none