Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with the master #3833

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Fix build with the master #3833

merged 1 commit into from
Mar 1, 2019

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Mar 1, 2019

rust-lang/rust#58689 broke compiletest.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 1, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Mar 1, 2019

📌 Commit df8a489 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Mar 1, 2019

⌛ Testing commit df8a489 with merge 9f20556...

bors added a commit that referenced this pull request Mar 1, 2019
Fix build with the master

rust-lang/rust#58689 broke compiletest.
@oli-obk
Copy link
Contributor

oli-obk commented Mar 1, 2019

You can send off these kind of PRs yourself, no need to wait for a review.

@mati865
Copy link
Contributor Author

mati865 commented Mar 1, 2019

I don't think I have the permission.

Anyway I think @ljedrz would appreciate if it was merged to enable_rust_lang_58754 branch.

@bors
Copy link
Contributor

bors commented Mar 1, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 9f20556 to master...

@bors bors merged commit df8a489 into rust-lang:master Mar 1, 2019
@mati865 mati865 deleted the rustup branch March 1, 2019 13:12
@ljedrz
Copy link
Contributor

ljedrz commented Mar 1, 2019

I can also branch off current master, no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants