Add several run rustfix annotations #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
flip1995
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 51c0dd4 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 14, 2019
…phansch Add several run rustfix annotations Adds `run-rustfix` to 18 of the tests from the tracking issue #3630. Each test has its own commit, to make reviewing easier (hopefully this is easier to review than 18 separate PRs). ## Changes - `cfg_attr_rustfmt`: Custom inner attributes are unstable. Let's disable the lint for inner attributes until [#54726](rust-lang/rust#54726) stabilizes - `collapsible_if`: unrelated cyclomatic_complexity warning that can be ignored - `duration_subsec`: Simply needed `#![allow(dead_code)]` - `excessive_precision`: Fixed by `#!allow(dead_code,unused_variables)` - `explicit_write`: Fixed by `#![allow(unused_imports)]` - `inconsistent_digit_grouping`: Avoid triggering `clippy::excessive_precision` lint - `infallible_destructuring_match`: Fixed by `#![allow(dead_code, unreachable_code, unused_variables)]` - `into_iter_on_ref`: Triggered unrelated `clippy::useless_vec` lint - `large_digit_groups`: Avoid triggering `clippy::excessive_precision` lint - `map_clone`: Fixed by `#![allow(clippy::iter_cloned_collect)]` - `mem_replace`: Suggestion causes import to be unused, fixed by `#![allow(unused_imports)]` - `precedence`: Allow some unrelated lints, and change out-of-range `0b1111_1111i8` literal - `redundant_field_names`: Allow dead code, and remove stabilized feature toggles - `replace_consts`: Fixed by `#![allow(unused_variables)]` - `starts_ends_with`: Fixed by `#![allow(unused_must_use)]` - `types`: Fixed by `#![allow(dead_code, unused_variables)]` - `unit_arg`: Fixed by `#[allow(unused_must_use)]` - `unnecessary_fold`: Fixed by adding type annotations and adding `#![allow(dead_code)]`
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
run-rustfixto 18 of the tests from the tracking issue #3630.Each test has its own commit, to make reviewing easier (hopefully this is easier to review than 18 separate PRs).
Changes
cfg_attr_rustfmt: Custom inner attributes are unstable. Let's disable the lint for inner attributes until #54726 stabilizescollapsible_if: unrelated cyclomatic_complexity warning that can be ignoredduration_subsec: Simply needed#![allow(dead_code)]excessive_precision: Fixed by#!allow(dead_code,unused_variables)explicit_write: Fixed by#![allow(unused_imports)]inconsistent_digit_grouping: Avoid triggeringclippy::excessive_precisionlintinfallible_destructuring_match: Fixed by#![allow(dead_code, unreachable_code, unused_variables)]into_iter_on_ref: Triggered unrelatedclippy::useless_veclintlarge_digit_groups: Avoid triggeringclippy::excessive_precisionlintmap_clone: Fixed by#![allow(clippy::iter_cloned_collect)]mem_replace: Suggestion causes import to be unused, fixed by#![allow(unused_imports)]precedence: Allow some unrelated lints, and change out-of-range0b1111_1111i8literalredundant_field_names: Allow dead code, and remove stabilized feature togglesreplace_consts: Fixed by#![allow(unused_variables)]starts_ends_with: Fixed by#![allow(unused_must_use)]types: Fixed by#![allow(dead_code, unused_variables)]unit_arg: Fixed by#[allow(unused_must_use)]unnecessary_fold: Fixed by adding type annotations and adding#![allow(dead_code)]