ci: when installing rust-toolchain-installer-master, install it in debug mode to save some time on ci. #3389
Conversation
…bug mode to save some time in ci. the compiletime optimizations probably take longer than the speedup we get when executing the optimized binary vs debug build.
|
Let's see if there are noticeable differences in wall time. |
|
Total build time is reduced by ~1 hour. master: https://travis-ci.org/rust-lang-nursery/rust-clippy/builds/448715468 |
|
Effective time reduction is 17 mins, since the jobs run in parallel. Which is still an improvement! |
|
When "normal" users (non- |
|
The only danger I can think of right now is that we could hit some kind of debug assert or overflows that would normally be optimized away/not emitted in release mode while running the installer, but it doesn't looks like the root crate containes any |
|
We could just merge this and see how it plays out on the next few PRs. If it fails too often we can disable it again, no harm done. |
|
LGTM, let's see how it works out 👍 bors r+ |
3389: ci: when installing rust-toolchain-installer-master, install it in debug mode to save some time on ci. r=phansch a=matthiaskrgr the compiletime optimizations probably take longer than the speedup we get when executing the optimized binary vs debug build. Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
Build failed |
|
Looks like |
|
bors r+ |
3389: ci: when installing rust-toolchain-installer-master, install it in debug mode to save some time on ci. r=phansch a=matthiaskrgr the compiletime optimizations probably take longer than the speedup we get when executing the optimized binary vs debug build. Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
the compiletime optimizations probably take longer than the speedup we get when executing the optimized binary vs debug build.