ci: allow all branches except trying.tmp and staging.tmp to be built #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you need to write Please also exclude The reason for the whitelist was, that PRs from within this Repo were checked twice. But PRs from this repo itself happen less than PRs from forks, so I guess blacklisting is indeed the better option. |
matthiaskrgr
changed the title
|
Sounds good to me 👍 bors: try (just checking if trying will also continue work) |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 26, 2018
3359: ci: allow all branches except trying.tmp and staging.tmp to be built r=phansch a=matthiaskrgr r? @flip1995 The problem was that with the current configuration, if I made a branch `feature1` and pushed it to travis to have it checked before making a PR, travis would skip it because it only built the 3 branches that were specified when setting up bors. The change allows all branch names to be build by default again, except for travis.tmp. The gh-pages branch is skipped as per travis-ci defaults: https://docs.travis-ci.com/user/customizing-the-build/#safelisting-or-blocklisting-branches Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
tryBuild failed |
Build failed |
|
rustc master crashes when checking hyper https://travis-ci.org/rust-lang-nursery/rust-clippy/jobs/446523247#L1846 :/ |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 26, 2018
3359: ci: allow all branches except trying.tmp and staging.tmp to be built r=phansch a=matthiaskrgr r? @flip1995 The problem was that with the current configuration, if I made a branch `feature1` and pushed it to travis to have it checked before making a PR, travis would skip it because it only built the 3 branches that were specified when setting up bors. The change allows all branch names to be build by default again, except for travis.tmp. The gh-pages branch is skipped as per travis-ci defaults: https://docs.travis-ci.com/user/customizing-the-build/#safelisting-or-blocklisting-branches Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
hcpl
added a commit
to hcpl/hashbrown
that referenced
this pull request
Oct 31, 2018
bors bot
added a commit
to rust-lang/hashbrown
that referenced
this pull request
Oct 31, 2018
15: Allow more branches to be built on CI r=Amanieu a=hcpl Adapted from rust-lang/rust-clippy#3359. Co-authored-by: hcpl <hcpl.prog@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @flip1995
The problem was that with the current configuration, if I made a branch
feature1and pushed it to travis to have it checked before making a PR, travis would skip it because it only built the 3 branches that were specified when setting up bors.The change allows all branch names to be build by default again, except for travis.tmp.
The gh-pages branch is skipped as per travis-ci defaults: https://docs.travis-ci.com/user/customizing-the-build/#safelisting-or-blocklisting-branches