Move uninlined_format_args back to style
#14160
Open
+235
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
nyurik
changed the title
uninlined_format_args to styleuninlined_format_args back to style
nyurik
force-pushed
the
style-uninlined-format-args
branch
from
67dfb8d to
91d43d6
Compare
|
r? @Alexendoo |
This lint was downgraded to `pedantic` in part because rust-analyzer was not fully supporting it at the time per rust-lang#10087. The support has been added over [a year ago](rust-lang/rust-analyzer#11260), so seems like this should be back to style. Another source of the initial frustration was fixed since then as well - this lint does not trigger by default in case only some arguments can be inlined.
This lint was downgraded to `pedantic` in part because rust-analyzer was not fully supporting it at the time per rust-lang#10087. The support has been added over [a year ago](rust-lang/rust-analyzer#11260), so seems like this should be back to style. Another source of the initial frustration was fixed since then as well - this lint does not trigger by default in case only some arguments can be inlined.
nyurik
force-pushed
the
style-uninlined-format-args
branch
from
91d43d6 to
3cce21d
Compare
tests/ui-toml/max_suggested_slice_pattern_length/index_refutable_slice.rs
Show resolved
Hide resolved
|
@samueltardieu I tried to minimize churn - reducing the changes. I just pushed the new commit making all tests a bit more consistent, where every test now has a different error line - making it much harder to review. |
|
Don't worry about the line number changes, we're very used to scrolling past them |
Alexendoo
added
S-final-comment-period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
uninlined_format_argswas temporarily downgraded topedanticin part because rust-analyzer was not fully supporting it at the time, per #10087. The support has been added over a year ago, so seems like this should be back to style.Another source of the initial frustration was fixed since then as well - this lint does not trigger by default in case only some arguments can be inlined.
changelog: [
uninlined_format_args]: move back tostyle