Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use multipart_suggestions for str_splitn #13789

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

scottgerring
Copy link
Contributor

This addresses #13099 for the manual_split_once test, using the str_splitn lint.

changelog: [str_splitn]: Updated str_splitn to use multipart_suggestions where appropriate

@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 6, 2024
@scottgerring scottgerring force-pushed the chore/fix_manual_split_once branch from 3702f41 to dcc4025 Compare December 6, 2024 15:04
@scottgerring scottgerring marked this pull request as ready for review December 6, 2024 15:17
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@Jarcho Jarcho added this pull request to the merge queue Dec 6, 2024
Merged via the queue into rust-lang:master with commit 5198941 Dec 6, 2024
9 checks passed
@scottgerring scottgerring deleted the chore/fix_manual_split_once branch December 6, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants