assigning_clones should respect MSRV

[humannum14916]

Fixes: #12502

This PR fixes the assigning_clones lint suggesting to use clone_from or clone_into on incompatible MSRVs.

assigning_clones will suggest using either clone_from or clone_into, both of which were stabilized in 1.63. If the current MSRV is below 1.63, the lint should not trigger.

changelog: [assigning_clones]: don't lint when the MSRV is below 1.63.

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[Alexendoo]

Great, thanks!

@bors r+

[bors]

📌 Commit 7c0b2dd has been approved by Alexendoo

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7c0b2dd with merge 89aba8d...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 89aba8d to master...

[Kobzol]

Hi, thanks for the PR, but I'm pretty sure that clone_from was not stabilized in 1.63 (https://doc.rust-lang.org/src/core/clone.rs.html#168). This should only limit clone_into.

[humannum14916]

Whoops! Sorry about that, I really should have double-checked exactly where to apply the MSRV check. I'll start working on a new PR to fix that, it looks like the proper location for the check would be in is_ok_to_suggest on a call.target of TargetTrait::ToOwned.