Add unnecessary_clippy_cfg lint
#12303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
flip1995
reviewed
Feb 16, 2024
Urgau
reviewed
Feb 16, 2024
GuillaumeGomez
force-pushed
the
unneedeed_clippy_cfg_attr
branch
from
916f589
to
38b039f
Compare
GuillaumeGomez
changed the title
unneeded_clippy_cfg_attr lintunnecessary_clippy_cfg lint
GuillaumeGomez
force-pushed
the
unneedeed_clippy_cfg_attr
branch
2 times, most recently
from
545b65f
to
f83d3a8
Compare
|
Fixed CI. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 18, 2024
…=Nadrieril Extend Level API I need this API for rust-lang/rust-clippy#12303: I have a nested `cfg` attribute (so a `MetaItem`) and I'd like to still be able to match against all possible kind of `Level`s.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 19, 2024
…=Nadrieril Extend Level API I need this API for rust-lang/rust-clippy#12303: I have a nested `cfg` attribute (so a `MetaItem`) and I'd like to still be able to match against all possible kind of `Level`s.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 19, 2024
…=Nadrieril Extend Level API I need this API for rust-lang/rust-clippy#12303: I have a nested `cfg` attribute (so a `MetaItem`) and I'd like to still be able to match against all possible kind of `Level`s.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 19, 2024
Rollup merge of rust-lang#121230 - GuillaumeGomez:extend-level-api, r=Nadrieril Extend Level API I need this API for rust-lang/rust-clippy#12303: I have a nested `cfg` attribute (so a `MetaItem`) and I'd like to still be able to match against all possible kind of `Level`s.
flip1995
reviewed
Feb 22, 2024
Comment on lines
+1003
to
+1004
| // FIXME: replace with `from_symbol` once https://github.com/rust-lang/rust/pull/121230 | ||
| // is merged. |
There was a problem hiding this comment.
The PR got merged. I will update this during the sync today.
GuillaumeGomez
force-pushed
the
unneedeed_clippy_cfg_attr
branch
from
f83d3a8
to
cf6a14c
Compare
|
Fixed nit and added new test case as suggested. |
|
@bors r+ Thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #12292.
r? @flip1995
changelog: Add
unnecessary_clippy_cfglint