Move uninhabited_references to nursery
#11997
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
|
Thank you for the PR! @flip1995 Could you take a look at this one? (You reviewed the original PR and would also do the beta backport, if we want to do it.) The issue #11984 suggests that the dereference is not the problem, but the actual creation of the type. If that's the case, I think it would be better to move the lint to |
|
Yeah, I think we should move it to |
TethysSvensson
changed the title
uninhabited_references to pedanticuninhabited_references to nursury
TethysSvensson
changed the title
uninhabited_references to nursuryuninhabited_references to nursery
|
@flip1995 I've updated the PR |
xFrednet
added
the
beta-nominated
|
Thank you for the PR! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Is there anything I need to do to get this backported to beta? |
|
The |
|
It's already too late for backporting it. I'll make sure that this line doesn't get into stable in the next release cycle though. |
|
@flip1995 Can we get a backport now, since it's still present in beta? Currently our CI is failing, because we run beta clippy in CI. I could disable that behavior, but I would prefer to keep it, since it's nice to get a heads-up on any lints before they hit stable. However in this case, it's not an issue we can (or want to) fix. |
|
I'll do an early backport once I get to it. I'm currently busy with catching up with my 1k notifications. Sorry for the inconvenience. |
…k-Simulacrum [beta] Clippy (early) beta backport Early backport of - rust-lang/rust-clippy#11997 This is causing some major issues for Clippy beta-users. As those are the ones that help testing new lints early, we want to fix their issues ASAP. r? `@Mark-Simulacrum` cc `@Manishearth`
flip1995
added
beta-accepted
xFrednet
removed
the
beta-accepted
I think this lint has too many false positives and should be put in pedantic. See #11984 and #11985 for context.
The lint is already in beta and is causing trouble for us, so I would also like this PR to be backported to beta as well.
changelog: Moved [
uninhabited_references] tonursery(Now allow-by-default)#11997
(Check if this has been backported)
Fixes #11984.