Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make macro_use_imports lint ordering more stable #11782

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

Alexendoo
Copy link
Member

changelog: none

Fixes the macro_use_imports ordering dependence on the hash of Spans

@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2023

r? @Centri3

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 9, 2023
Copy link
Member

@Centri3 Centri3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

clippy_lints/src/macro_use.rs Show resolved Hide resolved
@Centri3
Copy link
Member

Centri3 commented Nov 19, 2023

Thanks, @bors r+

@bors
Copy link
Collaborator

bors commented Nov 19, 2023

📌 Commit d8c0e64 has been approved by Centri3

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 19, 2023

⌛ Testing commit d8c0e64 with merge 9263f80...

@bors
Copy link
Collaborator

bors commented Nov 19, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Centri3
Pushing 9263f80 to master...

@bors bors merged commit 9263f80 into rust-lang:master Nov 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants