-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set doc-tests to no_run
#11699
Set doc-tests to no_run
#11699
Conversation
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
I wonder if it wouldn't be better to either use |
I think we should still be checking that the examples compile in CI, |
Ah, yes, we want to compile but not necessarily run the tests. That makes sense. @bors r+ |
Set doc-tests to `no_run` This excludes `should_panic` tests, those are still run to ensure they panic. Most of our other doc snippets don't gain much from being run though so this frees up a nice bit of CI time It also fixes the occasional issue such as `foo.txt`s being created https://github.com/rust-lang/rust-clippy/blob/f942470ca774b9648bac042f5d4c4ec74b81b61a/clippy_lints/src/permissions_set_readonly_false.rs#L19 changelog: none
💔 Test failed - checks-action_test |
For some reason the collect_metadata check failed. |
ea34aae
to
7347c18
Compare
Ah, there were a couple code blocks that got copied to |
Ok, let's try again. @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This excludes
should_panic
tests, those are still run to ensure they panic. Most of our other doc snippets don't gain much from being run though so this frees up a nice bit of CI timeIt also fixes the occasional issue such as
foo.txt
s being createdrust-clippy/clippy_lints/src/permissions_set_readonly_false.rs
Line 19 in f942470
changelog: none