Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite [tuple_array_conversions] #11171

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jul 17, 2023

Fixes #11100
Fixes #11144
Fixes #11124

#11082 still needs discussion and #11085 likely can't be fixed.

changelog: [tuple_array_conversions]: Move to pedantic
changelog: [tuple_array_conversions]: Don't lint if mutability of references changes
changelog: [tuple_array_conversions]: Don't lint if bindings don't come from the exact same pattern
changelog: [tuple_array_conversions]: Don't lint if bindings are used for more than just the conversion

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 17, 2023
@llogiq
Copy link
Contributor

llogiq commented Jul 18, 2023

Looks good to me. Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 18, 2023

📌 Commit 74a7704 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 18, 2023

⌛ Testing commit 74a7704 with merge 747df85...

@bors
Copy link
Collaborator

bors commented Jul 18, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 747df85 to master...

@bors bors merged commit 747df85 into rust-lang:master Jul 18, 2023
4 checks passed
@Centri3 Centri3 deleted the tuple_array_conversions branch July 18, 2023 05:31
Centri3 added a commit to Centri3/rust-clippy that referenced this pull request Jul 19, 2023
Also moves `tuple_array_conversions` to `pedantic`, because rust-lang#11171 didn't contain it fsr
Centri3 added a commit to Centri3/rust-clippy that referenced this pull request Jul 20, 2023
Also moves `tuple_array_conversions` to `pedantic`, because rust-lang#11171 didn't contain it fsr
Centri3 added a commit to Centri3/rust-clippy that referenced this pull request Jul 20, 2023
Also moves `tuple_array_conversions` to `pedantic`, because rust-lang#11171 didn't contain it fsr
Centri3 added a commit to Centri3/rust-clippy that referenced this pull request Jul 25, 2023
Also moves `tuple_array_conversions` to `pedantic`, because rust-lang#11171 didn't contain it fsr
Centri3 added a commit to Centri3/rust-clippy that referenced this pull request Jul 25, 2023
Also moves `tuple_array_conversions` to `pedantic`, because rust-lang#11171 didn't contain it fsr
Centri3 added a commit to Centri3/rust-clippy that referenced this pull request Aug 1, 2023
Also moves `tuple_array_conversions` to `pedantic`, because rust-lang#11171 didn't contain it fsr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
4 participants