Add imports_granularity = "Module" to rustfmt.toml
#11095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
What about |
|
I'd like to switch to rust-lang/rustfmt#5781 if that should get merged. |
|
Ooh I like that :) |
|
FWIW this also only modifies just under a third of the files, 195/605 (excluding tests since almost all of those are unchanged) |
flip1995
approved these changes
Jul 4, 2023
Manishearth
approved these changes
Jul 4, 2023
|
☔ The latest upstream changes (presumably #10788) made this pull request unmergeable. Please resolve the merge conflicts. |
Alexendoo
force-pushed
the
rustfmt-imports
branch
from
3928ece
to
2811eff
Compare
|
Let's create a bunch of conflicts! @bors r=Manishearth |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets rustfmt split/merge imports,
Moduleseems to be the most common style in clippyhttps://rust-lang.github.io/rustfmt/?version=v1.6.0&search=#imports_granularity
changelog: none
Almost all the updates other than the config file change are from
cargo dev fmtor blessed tests, the exceptions beingtests/ui/single_component_path_imports.rstests/ui/single_component_path_imports_nested_first.rstests/ui/single_component_path_imports_self_after.rstests/ui/single_component_path_imports_self_before.rstests/ui/unsafe_removed_from_name.rs(added a test with merged imports as a drive by)tests/ui/wildcard_imports.rstests/ui/wildcard_imports_2021.rs