Downgrade let_underscore_untyped to restriction #10442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
Agreed. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
This change didn't appear to make it to the 1.69.0 release branch; In practice for me, I can either make the fixes (which I'd prefer not to because I agree with @dtolnay's motivation in this issue) or add In the future, when lints have their categories changed before they make it to stable, would the team be able to cherry pick those changes to the stable branch? This PR did not have what I think was the intended effect of reducing churn for folks who enable clippy's |
|
Also, I'm not sure if I'm doing it wrong but I can't allow this lint from the command line. Does having $ cargo clippy -- --allow clippy::let_underscore_untyped
Checking scolapasta-hex v0.2.0 (/Users/lopopolo/dev/artichoke/artichoke/scolapasta-hex)
Checking artichoke-core v0.13.0 (/Users/lopopolo/dev/artichoke/artichoke/artichoke-core)
Checking scolapasta-aref v0.1.0 (/Users/lopopolo/dev/artichoke/artichoke/scolapasta-aref)
Checking scolapasta-path v0.5.0 (/Users/lopopolo/dev/artichoke/artichoke/scolapasta-path)
Checking spinoso-math v0.3.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-math)
Checking scolapasta-string-escape v0.3.0 (/Users/lopopolo/dev/artichoke/artichoke/scolapasta-string-escape)
Checking artichoke-load-path v0.1.0 (/Users/lopopolo/dev/artichoke/artichoke/artichoke-load-path)
Compiling artichoke v0.1.0-pre.0 (/Users/lopopolo/dev/artichoke/artichoke)
Compiling artichoke-backend v0.22.0 (/Users/lopopolo/dev/artichoke/artichoke/artichoke-backend)
Checking spinoso-random v0.3.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-random)
Checking spinoso-time v0.7.1 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-time)
Checking spinoso-array v0.9.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-array)
Checking mezzaluna-type-registry v1.0.1 (/Users/lopopolo/dev/artichoke/artichoke/mezzaluna-type-registry)
Checking spinoso-securerandom v0.2.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-securerandom)
Checking spinoso-regexp v0.5.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-regexp)
Checking spinoso-string v0.21.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-string)
Checking spinoso-env v0.2.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-env)
Checking spinoso-exception v0.1.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-exception)
Checking scolapasta-int-parse v0.2.2 (/Users/lopopolo/dev/artichoke/artichoke/scolapasta-int-parse)
Checking spinoso-symbol v0.3.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-symbol)
warning: non-binding `let` without a type annotation
--> spinoso-array/src/array/vec/convert.rs:115:9
|
115 | let _ = values;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
note: the lint level is defined here
--> spinoso-array/src/lib.rs:2:9
|
2 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::let_underscore_untyped)]` implied by `#[warn(clippy::pedantic)]`
warning: `spinoso-array` (lib) generated 1 warning
warning: non-binding `let` without a type annotation
--> spinoso-symbol/src/lib.rs:145:9
|
145 | let _ = err;
| ^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
note: the lint level is defined here
--> spinoso-symbol/src/lib.rs:2:9
|
2 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::let_underscore_untyped)]` implied by `#[warn(clippy::pedantic)]`
warning: `spinoso-symbol` (lib) generated 1 warning
warning: non-binding `let` without a type annotation
--> spinoso-regexp/src/lib.rs:404:13
|
404 | let _ = write!(&mut buf, "${num}");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
note: the lint level is defined here
--> spinoso-regexp/src/lib.rs:2:9
|
2 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::let_underscore_untyped)]` implied by `#[warn(clippy::pedantic)]`
warning: `spinoso-regexp` (lib) generated 1 warning
warning: non-binding `let` without a type annotation
--> spinoso-string/src/codepoints.rs:124:9
|
124 | let _ = write!(s, "{self}");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
note: the lint level is defined here
--> spinoso-string/src/lib.rs:2:9
|
2 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::let_underscore_untyped)]` implied by `#[warn(clippy::pedantic)]`
warning: `spinoso-string` (lib) generated 1 warning
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/artichoke.rs:48:13
|
48 | let _ = self.with_ffi_boundary(|mrb| sys::mrb_gc_protect(mrb, value));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
note: the lint level is defined here
--> artichoke-backend/src/lib.rs:2:9
|
2 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::let_underscore_untyped)]` implied by `#[warn(clippy::pedantic)]`
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/artichoke.rs:172:13
|
172 | let _ = mrb;
| ^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/block.rs:36:9
|
36 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/convert.rs:112:9
|
112 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/convert.rs:163:9
|
163 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/def.rs:280:9
|
280 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/def.rs:422:9
|
422 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/exception_handler.rs:105:9
|
105 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/array/ffi.rs:287:5
|
287 | let _ = mrb;
| ^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/array/mod.rs:239:9
|
239 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/array/mod.rs:308:9
|
308 | let _ = data;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
73 | ruby_exception_impl!(Exception);
| ------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
74 | ruby_exception_impl!(NoMemoryError);
| ----------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
75 | ruby_exception_impl!(ScriptError);
| --------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
76 | ruby_exception_impl!(LoadError);
| ------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
77 | ruby_exception_impl!(NotImplementedError);
| ----------------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
78 | ruby_exception_impl!(SyntaxError);
| --------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
79 | ruby_exception_impl!(SecurityError);
| ----------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
80 | ruby_exception_impl!(SignalException);
| ------------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
81 | ruby_exception_impl!(Interrupt);
| ------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
83 | ruby_exception_impl!(StandardError);
| ----------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
84 | ruby_exception_impl!(ArgumentError);
| ----------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
85 | ruby_exception_impl!(UncaughtThrowError);
| ---------------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
86 | ruby_exception_impl!(EncodingError);
| ----------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
87 | ruby_exception_impl!(FiberError);
| -------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
88 | ruby_exception_impl!(IOError);
| ----------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
89 | ruby_exception_impl!(EOFError);
| ------------------------------ in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
90 | ruby_exception_impl!(IndexError);
| -------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
91 | ruby_exception_impl!(KeyError);
| ------------------------------ in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
92 | ruby_exception_impl!(StopIteration);
| ----------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
93 | ruby_exception_impl!(LocalJumpError);
| ------------------------------------ in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
94 | ruby_exception_impl!(NameError);
| ------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
95 | ruby_exception_impl!(NoMethodError);
| ----------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
96 | ruby_exception_impl!(RangeError);
| -------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
97 | ruby_exception_impl!(FloatDomainError);
| -------------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
98 | ruby_exception_impl!(RegexpError);
| --------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
100 | ruby_exception_impl!(RuntimeError);
| ---------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
101 | ruby_exception_impl!(FrozenError);
| --------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
102 | ruby_exception_impl!(SystemCallError);
| ------------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
104 | ruby_exception_impl!(ThreadError);
| --------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
105 | ruby_exception_impl!(TypeError);
| ------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
106 | ruby_exception_impl!(ZeroDivisionError);
| --------------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
107 | ruby_exception_impl!(SystemExit);
| -------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
108 | ruby_exception_impl!(SystemStackError);
| -------------------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/exception/mod.rs:60:17
|
60 | let _ = interp;
| ^^^^^^^^^^^^^^^
...
110 | ruby_exception_impl!(Fatal);
| --------------------------- in this macro invocation
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
= note: this warning originates in the macro `ruby_exception_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/math/mod.rs:42:9
|
42 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/regexp/backend/onig.rs:124:9
|
124 | let _ = format_debug_escape_into(&mut pattern, self.source.pattern());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/regexp/backend/regex/utf8.rs:133:9
|
133 | let _ = format_debug_escape_into(&mut pattern, self.source.pattern());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/string/ffi.rs:696:5
|
696 | let _ = mrb;
| ^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/string/trampoline.rs:971:13
|
971 | let _ = dup.chomp(Some(sep));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/string/trampoline.rs:976:9
|
976 | let _ = dup.chomp(None::<&[u8]>);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/string/trampoline.rs:1014:5
|
1014 | let _ = dup.chop();
| ^^^^^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/string/mod.rs:35:9
|
35 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/string/mod.rs:138:9
|
138 | let _ = data;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/symbol/ffi.rs:245:5
|
245 | let _ = mrb;
| ^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/symbol/ffi.rs:254:5
|
254 | let _ = mrb;
| ^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/symbol/mod.rs:23:9
|
23 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/symbol/mod.rs:41:9
|
41 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/symbol/mod.rs:49:9
|
49 | let _ = value;
| ^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/symbol/mod.rs:50:9
|
50 | let _ = into;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/symbol/mod.rs:51:9
|
51 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/symbol/mod.rs:58:9
|
58 | let _ = data;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:164:5
|
164 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:165:5
|
165 | let _ = time;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:194:5
|
194 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:195:5
|
195 | let _ = time;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:203:5
|
203 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:204:5
|
204 | let _ = time;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:218:5
|
218 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:219:5
|
219 | let _ = time;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:220:5
|
220 | let _ = offset;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:231:5
|
231 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:232:5
|
232 | let _ = time;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:233:5
|
233 | let _ = offset;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:263:5
|
263 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:264:5
|
264 | let _ = time;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:321:5
|
321 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:322:5
|
322 | let _ = time;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:323:5
|
323 | let _ = num_digits;
| ^^^^^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:392:5
|
392 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:393:5
|
393 | let _ = time;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:398:5
|
398 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:399:5
|
399 | let _ = time;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:479:5
|
479 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/extn/core/time/trampoline.rs:480:5
|
480 | let _ = time;
| ^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/ffi.rs:87:9
|
87 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/fmt.rs:83:9
|
83 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/gc/arena.rs:49:9
|
49 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/intern.rs:136:9
|
136 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/interpreter.rs:109:9
|
109 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/io.rs:82:9
|
82 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/parser.rs:72:9
|
72 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/platform_string.rs:22:9
|
22 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/sys/mod.rs:101:5
|
101 | / let _ = write!(
102 | | &mut debug,
103 | | "{engine} {version} (v{MRUBY_RELEASE_MAJOR}.{MRUBY_RELEASE_MINOR}.{MRUBY_RELEASE_TEENY}) interpreter at {mrb:p}"
104 | | );
| |______^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: non-binding `let` without a type annotation
--> artichoke-backend/src/value.rs:353:9
|
353 | let _ = interp;
| ^^^^^^^^^^^^^^^
|
= help: consider adding a type annotation or removing the `let` keyword
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
warning: `artichoke-backend` (lib) generated 95 warnings
Finished dev [unoptimized + debuginfo] target(s) in 8.38s |
|
I'd like to plug a ticket I raised a while ago on this topic: Churn like that caused in this ticket leads to papercuts using clippy and a general expectation on my part that Rust toolchain upgrades will require some sort of workaround. I'm not sure of the best way to address this :| |
lopopolo
added a commit
to artichoke/artichoke
that referenced
this pull request
Apr 20, 2023
This lint was released as a pedantic lint in Rust 1.69.0 and later downgraded to a restriction lint. See: rust-lang/rust-clippy#10442 (comment)
This was referenced Apr 20, 2023
lopopolo
added a commit
to artichoke/qed
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From reading #6842 I am not convinced of the cost/benefit of this lint even as a pedantic lint.
It sounds like the primary motivation was to catch cases of
fn() -> Resultbeing changed toasync fn() -> Result. If the original Result was ignored by alet _, then the compiler wouldn't guide you to add.await. However, this situation is caught in a more specific way by let_underscore_future which was introduced after the original suggestion (#9760).In #10410 it was mentioned twice that a restriction lint might be more appropriate for let_underscore_untyped.
changelog: Moved [
let_underscore_untyped] to restriction