Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy::cargo_common_metadata ignores license-file metadata #4517

Closed
imp opened this issue Sep 7, 2019 · 0 comments · Fixed by #4518
Closed

clippy::cargo_common_metadata ignores license-file metadata #4517

imp opened this issue Sep 7, 2019 · 0 comments · Fixed by #4518

Comments

@imp
Copy link
Contributor

imp commented Sep 7, 2019 •
edited
Loading

Lint cargo::cargo_common_metadata checks for license property among the other things. However, it ignores the presense of the license-file property, which canbe used instead of the license (when the license is proprietary).

I would like to suggest checking for license-file as a fallback for missing license before emitting the warning.
imp added a commit to imp/rust-clippy that referenced this issue Sep 7, 2019
@imp
clippy::common-cargo-metadata: check for license-file
abc0b87 
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.

Fixes rust-lang#4517
@imp imp mentioned this issue Sep 7, 2019
Merged
@imp imp changed the title clippy::common-cargo-metadata ignores license-file metadata clippy::cargo_common_metadata ignores license-file metadata Sep 7, 2019
imp added a commit to imp/rust-clippy that referenced this issue Sep 7, 2019
@imp
clippy::cargo_common_metadata: check for license-file
1d2524a 
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.

Fixes rust-lang#4517
@imp imp mentioned this issue Sep 7, 2019
Closed
imp added a commit to imp/rust-clippy that referenced this issue Sep 7, 2019
@imp
clippy::cargo_common_metadata: check for license-file
0b389d1 
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.

Fixes rust-lang#4517
imp added a commit to imp/rust-clippy that referenced this issue Sep 7, 2019
@imp
clippy::cargo_common_metadata: check for license-file
ccef83c 
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.

Fixes rust-lang#4517
imp added a commit to imp/rust-clippy that referenced this issue Sep 8, 2019
@imp
clippy::cargo_common_metadata: check for license-file
373d6b0 
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.

Fixes rust-lang#4517
imp added a commit to imp/rust-clippy that referenced this issue Sep 11, 2019
@imp
clippy::cargo_common_metadata: check for license-file
137a762 
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.

Fixes rust-lang#4517
imp added a commit to imp/rust-clippy that referenced this issue Sep 18, 2019
@imp
clippy::cargo_common_metadata: check for license-file
eb6200c 
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.

Fixes rust-lang#4517
imp added a commit to imp/rust-clippy that referenced this issue Sep 21, 2019
@imp
clippy::cargo_common_metadata: check for license-file
bcf9e12 
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.

Fixes rust-lang#4517
bors added a commit that referenced this issue Sep 22, 2019
@bors
Auto merge of #4518 - imp:4517_license-file, r=phansch
157edad 
clippy::cargo_common_metadata: check for license-file

When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.

Fixes #4517

changelog: clippy::cargo_common_metadata now checks for license-file when license is missing
@bors bors closed this as completed in 4c881d1 Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clippy::cargo_common_metadata: check for license-file imp/rust-clippy
1 participant
@imp