-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #11587 - y21:into_iter_without_iter, r=Jarcho
new lint: `into_iter_without_iter` Closes #9736 (part 2) This implements the other lint that my earlier PR missed: given an `IntoIterator for &Type` impl, check that there exists an inherent `fn iter(&self)` method. changelog: new lint: `into_iter_without_iter` r? `@Jarcho` since you reviewed #11527 I figured it makes sense for you to review this as well?
- Loading branch information
Showing
5 changed files
with
357 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| //@no-rustfix | ||
| #![warn(clippy::into_iter_without_iter)] | ||
|
|
||
| use std::iter::IntoIterator; | ||
|
|
||
| fn main() { | ||
| { | ||
| struct S; | ||
|
|
||
| impl<'a> IntoIterator for &'a S { | ||
| //~^ ERROR: `IntoIterator` implemented for a reference type without an `iter` method | ||
| type IntoIter = std::slice::Iter<'a, u8>; | ||
| type Item = &'a u8; | ||
| fn into_iter(self) -> Self::IntoIter { | ||
| todo!() | ||
| } | ||
| } | ||
| impl<'a> IntoIterator for &'a mut S { | ||
| //~^ ERROR: `IntoIterator` implemented for a reference type without an `iter_mut` method | ||
| type IntoIter = std::slice::IterMut<'a, u8>; | ||
| type Item = &'a mut u8; | ||
| fn into_iter(self) -> Self::IntoIter { | ||
| todo!() | ||
| } | ||
| } | ||
| } | ||
| { | ||
| struct S<T>(T); | ||
| impl<'a, T> IntoIterator for &'a S<T> { | ||
| //~^ ERROR: `IntoIterator` implemented for a reference type without an `iter` method | ||
| type IntoIter = std::slice::Iter<'a, T>; | ||
| type Item = &'a T; | ||
| fn into_iter(self) -> Self::IntoIter { | ||
| todo!() | ||
| } | ||
| } | ||
| impl<'a, T> IntoIterator for &'a mut S<T> { | ||
| //~^ ERROR: `IntoIterator` implemented for a reference type without an `iter_mut` method | ||
| type IntoIter = std::slice::IterMut<'a, T>; | ||
| type Item = &'a mut T; | ||
| fn into_iter(self) -> Self::IntoIter { | ||
| todo!() | ||
| } | ||
| } | ||
| } | ||
| { | ||
| // Both iter and iter_mut methods exist, don't lint | ||
| struct S<'a, T>(&'a T); | ||
|
|
||
| impl<'a, T> S<'a, T> { | ||
| fn iter(&self) -> std::slice::Iter<'a, T> { | ||
| todo!() | ||
| } | ||
| fn iter_mut(&mut self) -> std::slice::IterMut<'a, T> { | ||
| todo!() | ||
| } | ||
| } | ||
|
|
||
| impl<'a, T> IntoIterator for &S<'a, T> { | ||
| type IntoIter = std::slice::Iter<'a, T>; | ||
| type Item = &'a T; | ||
| fn into_iter(self) -> Self::IntoIter { | ||
| todo!() | ||
| } | ||
| } | ||
|
|
||
| impl<'a, T> IntoIterator for &mut S<'a, T> { | ||
| type IntoIter = std::slice::IterMut<'a, T>; | ||
| type Item = &'a mut T; | ||
| fn into_iter(self) -> Self::IntoIter { | ||
| todo!() | ||
| } | ||
| } | ||
| } | ||
| { | ||
| // Only `iter` exists, no `iter_mut` | ||
| struct S<'a, T>(&'a T); | ||
|
|
||
| impl<'a, T> S<'a, T> { | ||
| fn iter(&self) -> std::slice::Iter<'a, T> { | ||
| todo!() | ||
| } | ||
| } | ||
|
|
||
| impl<'a, T> IntoIterator for &S<'a, T> { | ||
| type IntoIter = std::slice::Iter<'a, T>; | ||
| type Item = &'a T; | ||
| fn into_iter(self) -> Self::IntoIter { | ||
| todo!() | ||
| } | ||
| } | ||
|
|
||
| impl<'a, T> IntoIterator for &mut S<'a, T> { | ||
| //~^ ERROR: `IntoIterator` implemented for a reference type without an `iter_mut` method | ||
| type IntoIter = std::slice::IterMut<'a, T>; | ||
| type Item = &'a mut T; | ||
| fn into_iter(self) -> Self::IntoIter { | ||
| todo!() | ||
| } | ||
| } | ||
| } | ||
| { | ||
| // `iter` exists, but `IntoIterator` is implemented for an alias. inherent_impls doesn't "normalize" | ||
| // aliases so that `inherent_impls(Alias)` where `type Alias = S` returns nothing, so this can lead | ||
| // to fun FPs. Make sure it doesn't happen here (we're using type_of, which should skip the alias). | ||
| struct S; | ||
|
|
||
| impl S { | ||
| fn iter(&self) -> std::slice::Iter<'static, u8> { | ||
| todo!() | ||
| } | ||
| } | ||
|
|
||
| type Alias = S; | ||
|
|
||
| impl IntoIterator for &Alias { | ||
| type IntoIter = std::slice::Iter<'static, u8>; | ||
| type Item = &'static u8; | ||
| fn into_iter(self) -> Self::IntoIter { | ||
| todo!() | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.