Fix bugs in --clang-macro-fallback #3072
Merged
+44
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
|
I forgot to mention here that I'm doing some additional work on this so I changed it to a draft for the time being. I'll let you know when it's ready for review. |
jbaublitz
force-pushed
the
fixes-issue-3069-3070
branch
5 times, most recently
from
bde9266 to
69c3649
Compare
|
@pvdrz Is this CI failure related to the PR? It looks unrelated to me, but I'm not sure. |
jbaublitz
force-pushed
the
fixes-issue-3069-3070
branch
from
69c3649 to
1e87fed
Compare
jbaublitz
force-pushed
the
fixes-issue-3069-3070
branch
from
1e87fed to
7a675c0
Compare
|
My other bindgen PR fails in the same way as this one, so I'm going to consider it unrelated. @ojeda I think this is ready for you to take a look at it if you'd like. |
emilio
approved these changes
Feb 9, 2025
bindgen/lib.rs
Outdated
| .options | ||
| .clang_args | ||
| .iter() | ||
| .filter(|arg| !arg.contains("-MMD") && !arg.contains("-MD")) |
There was a problem hiding this comment.
Should this be starts_with? Also shouldn't we also skip the long-version of these? (--write-user-dependencies / --user-dependencies)?
jbaublitz
force-pushed
the
fixes-issue-3069-3070
branch
2 times, most recently
from
1127232 to
161131f
Compare
This commit resolves a bug where -include was not respected and a bug where -MMD was passed to the fallback translation unit which would cause the dependency file to be overwritten with useless information about temporary files.
jbaublitz
force-pushed
the
fixes-issue-3069-3070
branch
from
161131f to
76920aa
Compare
emilio
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3069
Closes #3070
I've tested the fixes, but would appreciate any additional feedback on this @ojeda.