Derive Debug and eq. comparison traits for InvalidRustTarget enum
#3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These traits are useful to get expressions like `RustTarget::stable(82, 0).unwrap()` to build, as `unwrap()` requires such a `Result` to implement `Debug`. The equality comparison traits may also be useful in cases where pattern matching the enum variants through e.g. `matches!` or match expressions is deemed less stylish.
AlexTMjugador
added a commit
to ComunidadAylas/vorbis-rs
that referenced
this pull request
Dec 13, 2024
This will make it slightly easier to target Rust's 2024 edition, where the `unsafe` keyword will be required for `extern` blocks like these. I'd like to also not use the now deprecated Rust version constants offered by `bindgen`, but the ergonomics of the alternative syntax can be improved and we can try to make it better upstream - see rust-lang/rust-bindgen#3055.
emilio
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These traits are useful to get expressions like
RustTarget::stable(82, 0).unwrap()to build, asunwrap()requires such aResultto implementDebug. The equality comparison traits may also be useful in cases where pattern matching the enum variants through e.g.matches!or match expressions is deemed less stylish. TheHashtrait is also derived in case anyone wants to put these variants into a hash table based data structure.