Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate possible undefined behaviour in rustified enum docs and point to alternative #1757

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Conversation

pheki
Copy link
Contributor

@pheki pheki commented Mar 25, 2020

As talked about in #1554, this intends to make it clear that non_exhaustive doesn't solve the UB problem and recommends using the newtype enum style instead of both types of rustified enum.

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants