Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StatusNotification #5782

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Fix StatusNotification #5782

merged 1 commit into from
Aug 17, 2020

Conversation

vsrs
Copy link
Contributor

@vsrs vsrs commented Aug 17, 2020

This PR fixes the following:

As per specification params property in NotificationMessage should be array | object while RA uses "loading" | "ready" | "invalid" | "needsReload".

@matklad
Copy link
Member

matklad commented Aug 17, 2020

Good catch!

bors r+

@matklad matklad mentioned this pull request Aug 17, 2020
Open
@bors
Copy link
Contributor

bors bot commented Aug 17, 2020

Build succeeded:

@bors bors bot merged commit 6826dd0 into rust-lang:master Aug 17, 2020
@vsrs vsrs deleted the fix_status_notification branch September 1, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsrs @matklad