Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak message shown for query fallback #522

Merged
merged 1 commit into from
Jan 13, 2019

Conversation

killercup
Copy link
Member

Small tweak for #518

@killercup
Copy link
Member Author

Originally noticed this because of:

bildschirmfoto 2019-01-13 um 13 27 27

It now only shows the second line of there are methods items to show.


I assume that Arc doesn't resolve in this snippet is a known bug:

use std::sync::{Arc, Mutex};

/// Structure holding your output targets
#[derive(Default, Clone)]
pub struct Output {
    inner: Arc<Mutex<InnerOutput>>,
}

but I can quickly open an issue if necessary

@DJMcNab
Copy link
Contributor

DJMcNab commented Jan 13, 2019

bors r+

Thanks! That's definitely a better user experience.

bors bot added a commit that referenced this pull request Jan 13, 2019
522: Tweak message shown for query fallback r=DJMcNab a=killercup

Small tweak for #518

Co-authored-by: Pascal Hertleif <killercup@gmail.com>
@flodiebold
Copy link
Member

flodiebold commented Jan 13, 2019

Hm. About Arc, std::sync gets properly resolved, but it reexports Arc from alloc_crate, which is an extern crate rename: extern crate alloc as alloc_crate. I guess that's the problem. I don't think we have an explicit bug for this...

@bors
Copy link
Contributor

bors bot commented Jan 13, 2019

Build succeeded

@bors bors bot merged commit 7f16f92 into rust-lang:master Jan 13, 2019
@killercup
Copy link
Member Author

Thanks for the quick merge! @flodiebold alright, I'll open an issue with a reproducible test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants