proc_macro: fix current nightly/future stable ABI incompatibility #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ I think we need it now? |
bors bot
added a commit
that referenced
this pull request
Jun 5, 2020
4676: proc_macro: fix current nightly/future stable ABI incompatibility r=matklad a=robojumper With rust-lang/rust#72233, the proc_macro ABI has changed, leading to the `test_derive_serialize_proc_macro` test believing (on nightly) that `serde` wants to pass the struct name as a byte string literal instead of a string literal. This fixes the test on nightly, but obviously breaks it on stable. As a result, this should be merged when Rust stable `1.45` releases on 2020-07-16. The PR is a draft as to not accidentally merge this too early. People working on nightly can simply apply the commit if they want a fully passing test suite. Co-authored-by: robojumper <robojumper@gmail.com>
|
bors r- Ah, no, I need it now, because I run beta... Gotta stick to stable I guess . |
|
Canceled. |
|
1.45 is out, we gotta merge this. |
|
Uh.. |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With rust-lang/rust#72233, the proc_macro ABI has changed, leading to the
test_derive_serialize_proc_macrotest believing thatserdewants to pass the struct name as a byte string literal instead of a string literal.Fixes #4866.