Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified debug lens #4366

Merged
merged 6 commits into from
May 8, 2020
Merged

Unified debug lens #4366

merged 6 commits into from
May 8, 2020

Conversation

vsrs
Copy link
Contributor

@vsrs vsrs commented May 7, 2020

Right now every debug engine gets the debug executable and exports the errors on its own.

This PR unifies the way all engines work. And adds an option to configure each engine separably.
For example, this adds visualizers for both CodeLLDB and C++ tools Windows debugger

"rust-analyzer.debug.engineSettings": {
    "cppvsdbg": {
        "visualizerFile": "${workspaceRoot}/rdisk.natvis"
    },
    "lldb": {
        "initCommands": [
            "command script import ${workspaceRoot}/rdisk.vis.py"
        ]
    }
}

bjorn3
bjorn3 reviewed May 7, 2020
View reviewed changes
editors/code/package.json Outdated Show resolved Hide resolved
@vsrs vsrs changed the title Uniformed debug lens Unified debug lens May 7, 2020
@vsrs vsrs mentioned this pull request May 8, 2020
Closed
vsrs and others added 2 commits May 8, 2020 19:22
@vsrs @bjorn3
"rust-analyzer.debug.openDebugPane"
1be6320 
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
@vsrs
Merge remote-tracking branch 'upstream/master' into uniformed_debug_lens
0ef17ef 
# Conflicts:
#	editors/code/src/commands/runnables.ts
@matklad
Copy link
Member

matklad commented May 8, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented May 8, 2020

Build succeeded:

@bors bors bot merged commit f1fa9aa into rust-lang:master May 8, 2020
@vsrs vsrs deleted the uniformed_debug_lens branch May 8, 2020 19:52
@jm-observer jm-observer mentioned this pull request Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsrs @matklad @bjorn3