Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parameter hints a bit & add emacs support #2875

Merged
merged 1 commit into from
Jan 18, 2020

Conversation

flodiebold
Copy link
Member

  • just include the name, not e.g. mut
  • don't return empty hints (or _)

CC @brotzeit for the Emacs change

 - just include the name, not e.g. `mut`
 - don't return empty hints (or `_`)
@matklad
Copy link
Member

matklad commented Jan 18, 2020

bors r+

bors bot added a commit that referenced this pull request Jan 18, 2020
2875: Improve parameter hints a bit & add emacs support r=matklad a=flodiebold

 - just include the name, not e.g. `mut`
 - don't return empty hints (or `_`)

CC @brotzeit for the Emacs change

Co-authored-by: Florian Diebold <flodiebold@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 18, 2020

Build succeeded

  • Rust (macos-latest)
  • Rust (ubuntu-latest)
  • TypeScript

@bors bors bot merged commit 18ec4e3 into rust-lang:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants