Improve/add use_item documentation #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Dec 5, 2018
| // Parse `use ::*;`, which imports all from the crate root in Rust 2015 | ||
| // This is invalid inside a use_tree_list, (e.g. `use some::path::{::*}`) | ||
| // but still parses and errors later: ('crate root in paths can only be used in start position') | ||
| // TODO: Add this error (if not out of scope) |
There was a problem hiding this comment.
We should add this error checking, but to the validator and not the parser:
There was a problem hiding this comment.
Yeah, it was just an overall comment that it was something that naturally comes up there, but should be added somewhere else.
|
Excellent, thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 5, 2018
253: Fix diagnostic fixes showing up everywhere r=matklad a=flodiebold The LSP code action request always returned the fixes for all diagnostics anywhere in the file, because of a shadowed variable. There's no test yet; I wasn't sure where to add it. I tried adding one in `heavy_tests`, but that's a bit uncomfortable because the code action response contains the (random) file paths. I could make it work, but wanted to ask beforehand what you think. 256: Improve/add use_item documentation r=matklad a=DJMcNab Adds some documentation to use_item explaining all code paths (use imports are hard, especially with the ongoing discussion of anchored v. uniform paths - see rust-lang/rust#55618 for what appears to be the latest developments) Co-authored-by: Florian Diebold <flodiebold@gmail.com> Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com>
Build failed (retrying...) |
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 6, 2018
256: Improve/add use_item documentation r=matklad a=DJMcNab Adds some documentation to use_item explaining all code paths (use imports are hard, especially with the ongoing discussion of anchored v. uniform paths - see rust-lang/rust#55618 for what appears to be the latest developments) Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some documentation to use_item explaining all code paths (use imports are hard, especially with the ongoing discussion of anchored v. uniform paths - see rust-lang/rust#55618 for what appears to be the latest developments)