-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor : fixes for ratoml module #17483
Conversation
rust-analyzer/crates/rust-analyzer/src/config.rs Lines 3610 to 3612 in bd9758b
I would also like to ( since it is relevant to this issue ) ask why this is supposed to be an error. If my assumption is correct it is related to the hyphenated key. If that's the case toml actually allows such keys. |
c81594d
to
630dc63
Compare
☔ The latest upstream changes (presumably #17488) made this pull request unmergeable. Please resolve the merge conflicts. |
Sprry forgot to reply to this. the error here is that |
- Parse errors are reflected as such by defining a new variant called `ConfigError::ParseError` - New error collection has been added to store config level agnostic errors.
crates/rust-analyzer/src/config.rs
Outdated
/// traversing through `global` configs and the `client` config. However the non-null value constraint | ||
/// is config level agnostic, so this requires an independent error storage | ||
/// FIXME : bad name I know... | ||
other_errors: ConfigErrors, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validation_errors
?
@bors delegate+ |
✌️ @alibektas, you can now approve this pull request! If @Veykril told you to " |
@bors r+ |
☀️ Test successful - checks-actions |
This is a follow-up PR to #17058.
ConfigError::ParseError
EDIT : Some things that this PR promised to solve are removed and will be addressed by other PRs