Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove extra parse cache from Semantics again #17380

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 10, 2024

Should fix #17376, specifically 30c04d5

The recent changes here were heavily triggering what I realized in #17367 (comment)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2024
@Veykril
Copy link
Member Author

Veykril commented Jun 10, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jun 10, 2024

📌 Commit 30c04d5 has been approved by Veykril

It is now in the queue for this repository.

@Veykril Veykril changed the title Thread more HasSource::source calls through Semantics for caching fix: Remove extra parse cache from Semantics again Jun 10, 2024
@bors
Copy link
Contributor

bors commented Jun 10, 2024

⌛ Testing commit 30c04d5 with merge 14a1f45...

@bors
Copy link
Contributor

bors commented Jun 10, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 14a1f45 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Error - 10:32:44 PM] Request textDocument/inlayHint failed.
3 participants