internal: Work through temporarily allowed clippy lints, part 2

[Urhengulas]

Another follow-up to #16401.

[bors]

☔ The latest upstream changes (presumably #16394) made this pull request unmergeable. Please resolve the merge conflicts.

[Veykril]

Seems like an import is missing or something

[Urhengulas]

Seems like an import is missing or something

Fixed

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

• c8ef65a

[Urhengulas]

@rustbot author

[Veykril]

@bors r+

[bors]

📌 Commit d1d9cde has been approved by Veykril

It is now in the queue for this repository.

[bors]

⌛ Testing commit d1d9cde with merge 698dbf8...

[bors]

💔 Test failed - checks-actions

[lnicola]

This came up a couple of times before and I think bjorn3 pointed put that most of the time we're going to have this variant, so making this change will cause a lot of allocations.

I don't know if the cost of moving the large struct around is lower or higher than that of the allocations, though.

[Urhengulas]

I am fine with any choice. I was just going with the clippy recommendation here.

I'd propose that we go with it and if someone takes the time to compare the two options we potentially revert it and disable the clippy lint for it.

[Veykril]

I think we should revert this and allow the lint, there is little reason for this change. But I'll do that in a follow up PR.

[Veykril]

#16470

[Veykril]

@bors r+

[bors]

📌 Commit df2c7a6 has been approved by Veykril

It is now in the queue for this repository.

[bors]

⌛ Testing commit df2c7a6 with merge 850ba2f...

[bors]

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 850ba2f to master...