-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a new config to allow renaming of non-local defs #16391
Merged
bors
merged 3 commits into
rust-lang:master
from
alibektas:15656/renaming_allowed_by_config
Jan 18, 2024
Merged
feat: Add a new config to allow renaming of non-local defs #16391
bors
merged 3 commits into
rust-lang:master
from
alibektas:15656/renaming_allowed_by_config
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With rust-lang#15656 we started disallowing renaming of non-local items. Although this makes sense there are some false positives that impacted users' workflows. So this config aims to mitigate this by giving users the liberty to disable this feature.
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 17, 2024
alibektas
changed the title
Add a new config to allow renaming of non-local items
Add a new config to allow renaming of non-local defs
Jan 17, 2024
The test runner was not aware of renames affecting multiple files so it just concatenated the changes. I fixed that and pushed it to your branch. |
Veykril
reviewed
Jan 18, 2024
Veykril
reviewed
Jan 18, 2024
@bors r+ |
☀️ Test successful - checks-actions |
lnicola
changed the title
Add a new config to allow renaming of non-local defs
feat: Add a new config to allow renaming of non-local defs
Jan 20, 2024
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #15656 we started disallowing renaming of non-local items. Although this makes sense there are some false positives that impacted users' workflows. So this config aims to mitigate this by giving users the liberty to disable this feature.
The reason why this is a draft is that I saw one of the tests fail and I am not sure if the "got" result even syntactically makes sense
Test case is :