Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show notable implemented traits on hover #16374

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 16, 2024

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2024
@Veykril
Copy link
Member Author

Veykril commented Jan 16, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jan 16, 2024

📌 Commit 3ac3413 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 16, 2024

⌛ Testing commit 3ac3413 with merge 85ae62f...

bors added a commit that referenced this pull request Jan 16, 2024
feat: Show notable trait impls on hover
@bors
Copy link
Contributor

bors commented Jan 16, 2024

💔 Test failed - checks-actions

@Veykril
Copy link
Member Author

Veykril commented Jan 16, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jan 16, 2024

📌 Commit 82e8355 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 16, 2024

⌛ Testing commit 82e8355 with merge 7777a81...

@bors
Copy link
Contributor

bors commented Jan 16, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 7777a81 to master...

@bors bors merged commit 7777a81 into rust-lang:master Jan 16, 2024
10 checks passed
bors added a commit that referenced this pull request Jan 16, 2024
feat: Goto type actions for notable trait hovers

Follow up to #16374
@lnicola lnicola changed the title feat: Show notable trait impls on hover feat: show notable implemented traits on hover Jan 20, 2024
@lnicola
Copy link
Member

lnicola commented Jan 22, 2024

image

@lnicola
Copy link
Member

lnicola commented Jan 22, 2024

This seems to work for variables, but looks a little weird for types:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants