Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Add minimal support for the 2024 edition #16151

Merged
merged 1 commit into from
Dec 18, 2023
Merged

internal: Add minimal support for the 2024 edition #16151

merged 1 commit into from
Dec 18, 2023

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Dec 18, 2023

CC #16146

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2023
@lnicola lnicola force-pushed the minimal-2024-edition branch from a0dfff1 to fec0e04 Compare December 18, 2023 15:10
davidbarsky
davidbarsky approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in a position to merge this, but lgtm.

(if my approval here is annoying, please let me know!)

@lnicola
Copy link
Member Author

lnicola commented Dec 18, 2023

@bors r=davidbarsky

@bors
Copy link
Contributor

bors commented Dec 18, 2023

📌 Commit fec0e04 has been approved by davidbarsky

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 18, 2023

⌛ Testing commit fec0e04 with merge 0ed815f...

@bors
Copy link
Contributor

bors commented Dec 18, 2023

☀️ Test successful - checks-actions
Approved by: davidbarsky
Pushing 0ed815f to master...

@bors bors merged commit 0ed815f into rust-lang:master Dec 18, 2023
10 checks passed
@lnicola lnicola deleted the minimal-2024-edition branch December 18, 2023 17:45
@lnicola lnicola mentioned this pull request Dec 27, 2023
Open
15 tasks
This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbarsky davidbarsky davidbarsky approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lnicola @bors @davidbarsky @rustbot