-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: move to Arc::from_iter
#15986
Conversation
6217d89
to
48d8393
Compare
...and rebased! |
Would be nice if I didn't have to rebase over this |
It's not as bad as it looks though, mainly |
Yeah, the change looks substantially noisier than it actually is, but there's no rush on landing this. |
its more it will conflict with my stuff and it touches things that I think i touched over multiple commits. Rebasing isnt really gonna be difficult but I'd also rather not have to rebase my stuff over this if I can avoid it |
yeah, fair. i'll wait to land this until your tokenmap work landed. |
☔ The latest upstream changes (presumably #16017) made this pull request unmergeable. Please resolve the merge conflicts. |
48d8393
to
c17dcc8
Compare
alright, this PR is no longer blocked. |
@bors r+ |
☀️ Test successful - checks-actions |
Builds atop of #15985, will rebase.