Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Bump deps pt. 1 #15902

Merged
merged 23 commits into from
Nov 15, 2023
Merged

internal: Bump deps pt. 1 #15902

merged 23 commits into from
Nov 15, 2023

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Nov 15, 2023

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2023
davidbarsky
davidbarsky reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that i'm a meaningful approver (beyond, I suppose, the tracing-related stuff), but lgtm :)

@lnicola
Copy link
Member Author

lnicola commented Nov 15, 2023

I was just asking you if you'd mind a PR to bump your tracing-log dependency to 0.2.

@lnicola lnicola marked this pull request as ready for review November 15, 2023 19:26
@lnicola
Copy link
Member Author

lnicola commented Nov 15, 2023

Thanks for the quick release, @davidbarsky!

r? @Veykril this isn't complete, but it might bit rot until I take it up again.

We drop atty, hermit-abi (probably unused), overload (from tracing-log), while gaining another itertools, which needs to be bumped in chalk.

@lnicola lnicola changed the title internal: Bump deps internal: Bump deps pt. 1 Nov 15, 2023
@lnicola
Copy link
Member Author

lnicola commented Nov 15, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2023

📌 Commit da24b6f has been approved by lnicola

It is now in the queue for this repository.

@Veykril
Copy link
Member

Veykril commented Nov 15, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2023

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Nov 15, 2023

📌 Commit da24b6f has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 15, 2023

⌛ Testing commit da24b6f with merge 58de0b1...

@bors
Copy link
Contributor

bors commented Nov 15, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 58de0b1 to master...

@bors bors merged commit 58de0b1 into rust-lang:master Nov 15, 2023
@bors bors mentioned this pull request Nov 15, 2023
Closed
@lnicola lnicola deleted the bump-deps branch November 15, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbarsky davidbarsky davidbarsky left review comments

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lnicola @bors @Veykril @davidbarsky @rustbot