fix: Disallow renaming of non-local items #15232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
I think it should include all items (ADTs, functions, consts, ...) |
alibektas
changed the title
lowr
reviewed
Jul 8, 2023
crates/ide-db/src/rename.rs
Outdated
Comment on lines
87
to
97
| if mac.is_builtin_derive(sema.db) { | ||
| bail!("Cannot rename builtin macro") | ||
| } |
There was a problem hiding this comment.
Can you also add a test for this?
There was a problem hiding this comment.
I can't seem to find a way that would bypass Cannot rename a non-local definition. and bail out at Cannot rename builtin derive
lowr
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #15377) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rustbot review |
rustbot
added
S-waiting-on-review
Veykril
reviewed
Sep 8, 2023
Veykril
added
S-waiting-on-author
Veykril
approved these changes
Sep 11, 2023
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14850 . This makes me wonder , why stop at structs and not do the same for other ADTs? Would be happy to add them too if nothing speaks against it.