Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make make_body respect comments in extract_function #13746

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fix: make make_body respect comments in extract_function #13746

merged 1 commit into from
Dec 12, 2022

Conversation

feniljain
Copy link
Contributor

@feniljain feniljain commented Dec 9, 2022 •
edited
Loading

Possible fix for #13621

Points to help in review:

  • Earlier we were only considering statements in a block expr and hence comments were being ignored, now we handle tokens hence making it aware of comments and then preserving them using hacky_block_expr_with_comments

Seems like I am not able to attach output video, github is glitching for it :(

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2022
@jonas-schievink
Copy link
Contributor

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 12, 2022

📌 Commit d7183fb has been approved by jonas-schievink

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 12, 2022

⌛ Testing commit d7183fb with merge 4596847...

@bors
Copy link
Contributor

bors commented Dec 12, 2022

☀️ Test successful - checks-actions
Approved by: jonas-schievink
Pushing 4596847 to master...

@bors bors merged commit 4596847 into rust-lang:master Dec 12, 2022
@bors bors mentioned this pull request Dec 12, 2022
Closed
@jplatte jplatte mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@feniljain @jonas-schievink @bors @rustbot