-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow viewing the full compiler diagnostic in a readonly textview #13633
Conversation
52319f9
to
073a63b
Compare
That is just VSCode rendering the diagnostic messages you see on hover in the red box, not much we can do there |
37e744a
to
8452844
Compare
Really, they don't allow putting a full diagnostic in there? Why do they even have that button then? |
VSCode basically allows you to do nothing with diagnostics :) |
😭 |
@bors r+ |
☀️ Test successful - checks-actions |
We need to make it so when people copy the diagnostic it'll copy the full diagnostic (don't think we can do that, unfortunately). |
What exactly do you mean with that? |
People many times ask for help with the truncated rust-analyzer diagnostic. It would be nice if copying it would result in the full diagnostic being copied. |
Also adds a VSCode only config that replaces the split diagnostic message with the first relevant part of the diagnostic output
This only affects diagnostics generated by primary spans and has no effect on other clients than VSCode.
Fixes #13574