Panic in ast_transform #6092
Assignees
Comments
|
CC #4086 |
|
I can reproduce with: and then selecting the "Implement default members" assist. |
matthewsanetra
pushed a commit
to matthewsanetra/rust-analyzer
that referenced
this issue
Oct 8, 2020
matthewsanetra
added a commit
to matthewsanetra/rust-analyzer
that referenced
this issue
Oct 9, 2020
* Add convert integer literal assist * Add ability to specify ResolvedAssist by label * Add tests for convert integer literal assist * Minor clippy performance suggestions * Fix path comparison not comparing paths correctly with unequal lengths * Improve grammar and fix code example in style guide * Up rustc-ap-rustc_lexer to 681 cargo update as well * Document Clippy strategy * Add support of runnables arguments in Rust Analyzer * Replace 'cargo_prefix' option with 'override_cargo' * Support 'runnables' options in the vs code extension * Fix failing test * Add postfix completion for format-like string literals * Improve checks for postfix suggestions * Simplify is_string_literal function * Add missing entry to doc-comment * Improve format-like completions code appearance * Use ast::String for extracting string literal contents * Use lookup table instead of enum for postfix completion kinds * Use expect_test to make format_str_parser test more data-driven * Reduce visibiity * Expectify find_references tests * Move ide::AnalysisChange -> base_db::Change This seems like a better factoring logically; ideally, clients shouldn't touch `set_` methods of the database directly. Additionally, I think this should remove the unfortunate duplication in fixture code. * Rewrite fixtures on top of Change * Get rid of MockAnalysis * rename mock_analysis -> fixture * Add a dash test * Fix the hover dash issues * Properly name the field * Simplify ast_transform * Correctly complete items with leading underscore * Better inlay hints in 'for' loops * Make the tests for complete/incomplete for inlay hints work * Remove 'for_expr' test from inlay_hints.rs * Improve readability in inlay_hints.rs * Trim all trailing whitespace in onEnter Fixes rust-lang#5848 * Add notes concerning privacy and network access * Make find_path_prefixed configurable * Make ImportPrefix a configuration option * honor content_format clientcap This removes all markdown when the client does not support the markdown MarkupKind Otherwise the output on the editor will have some markdown boilerplate, making it less readable * add docstring * Fix feature name * Account for proc macro helpers when parsing attr * Do not leave braces for colons in dbg! * Fix trait object hir formatting behind pointer and references * Smoke test docs generation * Move ModPath->ast::Path function to IDE layer closes rust-lang#6092 * add doc describing limited capabilities * add break after codeblocks * Constrain ImportMap to only store simple paths * Shorten type hints for std::iter Iterators * Add test makr * Document privacy invariant of SyntaxPtr * Use FamousDefs for shorten_iterator hint * Fixed parsing of negative number literals in macros. * Added unit test for negative number literals in macros. * Update manual.adoc * Add validation check for ambiguous trait objects * Bump chalk to use latest git to get fix * Chalk very recently (like an hour ago) merged a fix that prevents rust analyzer from panicking. This allows it to be usable again for code that hits those situations. See rust-lang#6134, rust-lang#6145, Probably rust-lang#6120 * `todo!()` -> `unimplemented!() // FIXME` for CI * Make unimplemented match variants explicit * Move IntoIterator into FamousDefs * Shorten iterator chain hints * Cleanup * Shorten iterator hints for std::iter iterators behind references * Better progress API Percentage is a UI concern, the physical fact here is fraction. It's sad that percentage bleeds into the protocol level, we even duplicated this bad API ourselves! * Reorg style * Add comparisons guideline to style * minor * minor * Clean up inlay_hints * Switch from git to latest tagged release of chalk deps * Add track_env_var to the proc macro server * Bump rustc_lexer, cfg-if to 1.0 and add new license to check * add eprintln in fmt-like postfix Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com> * Fix source_to_def for named enum variant fields * Add note if RUST_SRC_PATH is likely to be wrong * Update crates/project_model/src/sysroot.rs Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com> * Remove release build overrides * Treat `ast::Name` in field patterns as use * adt: correctly inherit field visibility from enum Previously, "find all references" on a variant field wouldn't find any references outside the defining module. This is because variant fields were incorrectly assumed to be private, like struct fields without explicit visibility, but they actually inherit the enum's visibility. Co-authored-by: vlakreeh <zeb@zebulon.dev> Co-authored-by: kjeremy <kjeremy@gmail.com> Co-authored-by: Lukas Wirth <lukastw97@gmail.com> Co-authored-by: Laurențiu Nicola <lnicola@dend.ro> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com> Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com> Co-authored-by: Igor Aleksanov <popzxc@yandex.ru> Co-authored-by: Kirill Bulatov <mail4score@gmail.com> Co-authored-by: León Orell Valerian Liehr <liehr.exchange@gmx.net> Co-authored-by: Wesley Norris <repnop@outlook.com> Co-authored-by: Robin van Dijk <robin@robinjint.nl> Co-authored-by: Jonas Schievink <jonasschievink@gmail.com> Co-authored-by: Tim <tim@glacyr.com> Co-authored-by: Adrian Stanciu <stanciu.adrian@gmail.com> Co-authored-by: Casey Primozic <me@ameo.link> Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com> Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: