Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill in SymbolInformation container_name from workspace/symbol query #559

Closed
kjeremy opened this issue Jan 16, 2019 · 1 comment · Fixed by #813
Closed

Fill in SymbolInformation container_name from workspace/symbol query #559

kjeremy opened this issue Jan 16, 2019 · 1 comment · Fixed by #813
Labels
E-has-instructions Issue has some instructions and pointers to code to get started E-medium good first issue

Comments

@kjeremy
Copy link
Contributor

kjeremy commented Jan 16, 2019

It would be nice to fill this in for the UI.
@matklad matklad added good first issue E-medium E-has-instructions Issue has some instructions and pointers to code to get started labels Jan 26, 2019
@matklad
Copy link
Member

matklad commented Jan 26, 2019 •
edited
Loading

Will need to add additional info to FileSymbol struct:

https://github.com/rust-analyzer/rust-analyzer/blob/0974e6abeb9c3f047e21c3e23769b93c9e7dcaf3/crates/ra_ide_api/src/symbol_index.rs#L208-L213

And we should add more context to the to_symbol function such that it actually knows the parent:

https://github.com/rust-analyzer/rust-analyzer/blob/0974e6abeb9c3f047e21c3e23769b93c9e7dcaf3/crates/ra_ide_api/src/symbol_index.rs#L215-L231

@vipentti vipentti mentioned this issue Feb 12, 2019
Merged
bors bot added a commit that referenced this issue Feb 13, 2019
@bors @vipentti
Merge #813
65266c6 
813: Add support for container_name in workspace/symbol query r=matklad a=vipentti

Currently this does not fill in the container_info if a type is defined on the top level in a file. 

e.g. `foo.rs`
```rust
enum Foo { }
```
`Foo` will have None as the container_name, however

```rust
mod foo_mod {
    enum Foo { } 
}
```
`Foo` has `foo_mod` as the container_name. 

This closes #559 

Co-authored-by: Ville Penttinen <villem.penttinen@gmail.com>
@bors bors bot closed this as completed in #813 Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-has-instructions Issue has some instructions and pointers to code to get started E-medium good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for container_name in workspace/symbol query vipentti/rust-analyzer
2 participants
@matklad @kjeremy