Skip to content

Commit

Permalink
Merge #6161
Browse files Browse the repository at this point in the history
6161: Bump chalk to use latest git to get upstream fix r=jonas-schievink a=Ameobea

 * Chalk very recently (like an hour ago) merged a fix that prevents rust analyzer from panicking.  This allows it to be usable again for code that hits those situations.  See #6134, #6145, Probably #6120

Co-authored-by: Casey Primozic <me@ameo.link>
  • Loading branch information
bors[bot] and Ameobea authored Oct 7, 2020
2 parents 83a651b + 37df213 commit e95e666
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 12 deletions.
16 changes: 8 additions & 8 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions crates/hir_ty/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ ena = "0.14.0"
log = "0.4.8"
rustc-hash = "1.1.0"
scoped-tls = "1"
chalk-solve = { version = "0.30.0" }
chalk-ir = { version = "0.30.0" }
chalk-recursive = { version = "0.30.0" }
chalk-solve = "0.32"
chalk-ir = "0.32"
chalk-recursive = "0.32"

stdx = { path = "../stdx", version = "0.0.0" }
hir_def = { path = "../hir_def", version = "0.0.0" }
Expand Down
14 changes: 14 additions & 0 deletions crates/hir_ty/src/traits/chalk.rs
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,20 @@ impl<'a> chalk_solve::RustIrDatabase<Interner> for ChalkContext<'a> {
fn fn_def_name(&self, fn_def_id: chalk_ir::FnDefId<Interner>) -> String {
format!("fn_{}", fn_def_id.0)
}
fn generator_datum(
&self,
_: chalk_ir::GeneratorId<Interner>,
) -> std::sync::Arc<chalk_solve::rust_ir::GeneratorDatum<Interner>> {
// FIXME
unimplemented!()
}
fn generator_witness_datum(
&self,
_: chalk_ir::GeneratorId<Interner>,
) -> std::sync::Arc<chalk_solve::rust_ir::GeneratorWitnessDatum<Interner>> {
// FIXME
unimplemented!()
}
}

pub(crate) fn program_clauses_for_chalk_env_query(
Expand Down
2 changes: 2 additions & 0 deletions crates/hir_ty/src/traits/chalk/mapping.rs
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,8 @@ impl ToChalk for TypeCtor {
// this should not be reached, since we don't represent TypeName::Error with TypeCtor
unreachable!()
}
TypeName::Generator(_) => unimplemented!(), // FIXME
TypeName::GeneratorWitness(_) => unimplemented!(), // FIXME
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion editors/code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1048,4 +1048,4 @@
]
}
}
}
}

0 comments on commit e95e666

Please sign in to comment.