Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Add docs to completion #903

Merged
merged 1 commit into from
Jun 9, 2018
Merged

Conversation

alexheretic
Copy link
Member

Resolves #513

@Xanewok
Copy link
Member

Xanewok commented Jun 9, 2018

Well, that was simple enough. Not sure what I referred to in #513 (comment). Is it possible that Racer started also including docs in the completion data in the meantime?

Thanks!

@Xanewok Xanewok merged commit 206a9fb into rust-lang:master Jun 9, 2018
@alexheretic
Copy link
Member Author

Yeah that's what I assume, lsp supports markdown docs now too so everything lined up nicely :).

@alexheretic alexheretic deleted the completion-docs branch June 9, 2018 11:46
@pravic
Copy link

pravic commented Jun 13, 2018

Just curious, when this build will be available on a nightly Rust version? Today's nightly still contains

rls-preview 0.128.0-nightly (7d0bc55 2018-06-07).

@alexheretic
Copy link
Member Author

@pravic the commit in the nightly releases is the latest submodule commit reference to this project over in rust-lang/rust. It was last updated about a week ago by rust-lang/rust#51407.

@nrc will usually raise prs to update it fairly frequently, you could even raise one yourself. Another option for the impatient is to simply checkout rls and build it for yourself. Your client should have a decent way to allow this. I do this myself currently because I like clippy.

@pravic
Copy link

pravic commented Jun 14, 2018

Thanks for the advice. I'll try to build it locally. Lack of documentation in popups (among others) is really frustrating.

@pravic
Copy link

pravic commented Jul 4, 2018

Works excellently. Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants