Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

suggestion: label namespaces on hover #974

Closed
sophiajt opened this issue Jul 31, 2018 · 3 comments
Closed

suggestion: label namespaces on hover #974

sophiajt opened this issue Jul 31, 2018 · 3 comments

Comments

@sophiajt
Copy link

Was thinking about how we hadn't added any text to the hover when you hover a namespace/crate etc and how it'll be more likely that people do that with the 2018 edition.

What if there was a hover text but it said something simple like "module"? Just so people know there is something there, and to keep looking for something with more info.

One step better would be to allow navigation to those locations. But, at the very least, just let them know that the system is working but there just isn't much useful information at that location.

@alexheretic
Copy link
Member

Thanks to the recent work by @aloucks / #930 rls does now provide more for this case.

Here are some examples of rls master in atom
hover-crate
hover-std

@sophiajt
Copy link
Author

@alexheretic - perfect! that's even better than I was thinking. Will wait for it to hit nightly.

@Xanewok
Copy link
Member

Xanewok commented Nov 30, 2018

This seems to work and we can now go-to them, so I'll close this 🎉 (sometimes failing goto tracked at #1106)

@Xanewok Xanewok closed this as completed Nov 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants