Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover/navigate to symbol works only partially [LSP4E, RLS] #108

Closed
norru opened this issue Aug 13, 2018 · 5 comments
Closed

Hover/navigate to symbol works only partially [LSP4E, RLS] #108

norru opened this issue Aug 13, 2018 · 5 comments
Labels
upstream-rls Issues requiring work in the Rust Language Server. Those issues should link to RLS issues.

Comments

@norru
Copy link
Contributor

norru commented Aug 13, 2018

Most symbols hover yield to the following in the logs:

org.eclipse.corrosion.rls to LSP4E:{"jsonrpc":"2.0","id":1189,"result":{"contents":[],"range":null}}

as a result, hover click on non-leaf symbols

  • module names
  • trait names
  • macros

doesn't have any effect.

For instance, in a line such as

Message::Event(Event::PickMinion(position))

Hover/navigate works for the symbols PickMinion, position and the first instance of Event
Hover/navigate does not work for the symbols Message, seconds instance of Event

Expected action would be to always be able to hint/navigate to where any symbol is defined.

@LucasBullen
Copy link

All hover results are generated in the Rust Language Server. I'm not knowledgeable in Rust, so the cause for only giving hover results on the first Event but not the second might have already been explained in their Issues, but if not then opening an issue there would be the proper course of action.

@LucasBullen LucasBullen added the upstream-rls Issues requiring work in the Rust Language Server. Those issues should link to RLS issues. label Aug 14, 2018
@norru
Copy link
Contributor Author

norru commented Aug 14, 2018

rust-lang/rls#974? The feature seems to have been implemented but the hover is still mute.

@norru
Copy link
Contributor Author

norru commented Aug 14, 2018

rust-lang/rls#930

@norru norru changed the title Hover/navigate to symbol works only partially [LSP4E, RLS Hover/navigate to symbol works only partially [LSP4E, RLS] Aug 14, 2018
@norru
Copy link
Contributor Author

norru commented Aug 14, 2018

rust-lang/rls#991

@norru
Copy link
Contributor Author

norru commented Nov 5, 2018

This now works for everything except for Enum names.

@norru norru closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream-rls Issues requiring work in the Rust Language Server. Those issues should link to RLS issues.
Projects
None yet
Development

No branches or pull requests

2 participants