Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Deprecate std::fmt::format in favor of String::format #810

Closed
wants to merge 2 commits into from

Conversation

kmcallister
Copy link
Contributor

@seanmonstar
Copy link
Contributor

See also #583 (comment) and seanmonstar/rust@031c512


# Drawbacks

None! Perfect RFC!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pnkfelix pnkfelix assigned pnkfelix and alexcrichton and unassigned pnkfelix Feb 5, 2015
@aturon
Copy link
Member

aturon commented Mar 5, 2015

ping @alexcrichton

@kmcallister
Copy link
Contributor Author

Updated for the changes in rust-lang/rust#21912.

@alexcrichton
Copy link
Member

@aturon and I had a chat on IRC about whether we really need a #[stable] API here at all. The conclusion was basically that we for now should take the most conservative route possible by stabilizing as few APIs as possible.

With the advent of #[allow_internal_unstable] there's no actual need to have a stable API corresponding to the implementation detail of the format! macro. As a result, we will likely want to destabilize fmt::format in which case a change such as this would no longer require an RFC (but could still be done regardless).

In light of that information I'm going to close this RFC, and I think you're free to make this change as soon as #22899 lands basically.

Thanks again for the RFC, and sorry for being a little slow on the sheperding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants