Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the deriving syntax extension to derive #534

Merged
merged 1 commit into from
Dec 31, 2014
Merged

Rename the deriving syntax extension to derive #534

merged 1 commit into from
Dec 31, 2014

Conversation

bstrie
Copy link
Contributor

@bstrie bstrie commented Dec 19, 2014

@emberian
Copy link
Member

+1, I make this mistake surprisingly often, and it reads better.

@tomjakubowski
Copy link
Contributor

Consistency and brevity with no loss in clarity make this an easy 👍 from me.

@lilyball
Copy link
Contributor

:shipit:

@barosl
Copy link
Contributor

barosl commented Dec 19, 2014

+1 and it's definitely not "too late"!

@aturon
Copy link
Member

aturon commented Dec 19, 2014

Yes please!

@blaenk
Copy link
Contributor

blaenk commented Dec 19, 2014

Good one kibwen

@flaper87
Copy link

PLEASE!

@liigo
Copy link
Contributor

liigo commented Dec 22, 2014

nice

@Ericson2314
Copy link
Contributor

+1. Besides the reasons given, in Haskell it comes after the deceleration, but in Rust it comes first.

@8573
Copy link

8573 commented Dec 28, 2014

++

@theemathas
Copy link

+1.deriving is the only attribute that ends with "ing". We also have use, not using. Additionally, for the type declaration with deriving to read like a grammatically correct English sentence, deriving must come after the type declaration (which it doesn't).

It is much more consistent to use "derive" than "deriving"

@nrc nrc self-assigned this Dec 30, 2014
@nrc
Copy link
Member

nrc commented Dec 31, 2014

We discussed this at today's meeting and approve, merging.

Tracking issue

@nrc nrc merged commit f57d108 into rust-lang:master Dec 31, 2014
@Centril Centril added A-derive Deriving related proposals & ideas A-attributes Proposals relating to attributes labels Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Proposals relating to attributes A-derive Deriving related proposals & ideas
Projects
None yet
Development

Successfully merging this pull request may close these issues.