Un-feature-gate struct variants

[sfackler]

rendered

[sfackler]

I don't know if this kind of change requires an RFC but here it is anyway!

[aturon]

Sounds good to me, thanks for writing this up!

[brendanzab]

👍

[blaenk]

Good idea.

[brson]

I feel like we originally put this behind a gate because we were not confident about it and intended it to be on the path to deprecation. My understanding is this change is motivated because there are a fair number of libraries using it. Are we sure we like this feature now?

[netvl]

+1. Struct variants are essential for nice structuring of parsing events, I use them all the time.

[luqmana]

@brson I feel like we originally put the feature gate in place because there were various bugs present and just not enough people using them at the time. But, afaik all those bugs have since been fixed.

[alexcrichton]

@sfackler, could you update the RFC with these changes as well to the detailed design section?

• Forbid pub on fields of struct variants
• The visibility of a struct variant's field is inherited from the enum itself

Other than that, this is good to go!

[sfackler]

@alexcrichton updated

[alexcrichton]

Tracking

Discussion

[alexcrichton]

Thanks @sfackler!